diff --git a/javascript/ql/lib/change-notes/2026-11-21-xss-replaceall-string-sanitizer.md b/javascript/ql/lib/change-notes/2026-11-21-xss-replaceall-string-sanitizer.md new file mode 100644 index 000000000000..a57da08ab536 --- /dev/null +++ b/javascript/ql/lib/change-notes/2026-11-21-xss-replaceall-string-sanitizer.md @@ -0,0 +1,4 @@ +--- +category: minorAnalysis +--- +* A `replaceAll` call whose string pattern is `<`, `'` or `"`, such as `s.replaceAll("<", "<")`, is now recognized as a sanitizer by the cross-site scripting queries, such as `js/xss`, `js/reflected-xss` and `js/stored-xss`, in the same way as a global regular expression replacement. diff --git a/javascript/ql/lib/semmle/javascript/security/dataflow/Xss.qll b/javascript/ql/lib/semmle/javascript/security/dataflow/Xss.qll index f139ccc48dbb..0fc32919595e 100644 --- a/javascript/ql/lib/semmle/javascript/security/dataflow/Xss.qll +++ b/javascript/ql/lib/semmle/javascript/security/dataflow/Xss.qll @@ -31,7 +31,7 @@ module Shared { abstract class Sanitizer extends DataFlow::Node { } /** - * A global regexp replacement involving the `<`, `'`, or `"` meta-character, viewed as a sanitizer for + * A global replacement involving the `<`, `'`, or `"` meta-character, viewed as a sanitizer for * XSS vulnerabilities. */ class MetacharEscapeSanitizer extends Sanitizer, StringReplaceCall { @@ -42,6 +42,10 @@ module Shared { or // or it's like a wild-card. RegExp::isWildcardLike(this.getRegExp().getRoot()) + or + // or it's a `replaceAll` call whose string pattern is a meta-character. + this.getMethodName() = "replaceAll" and + forex(string s | this.getArgument(0).mayHaveStringValue(s) | s = ["<", "'", "\""]) ) } } diff --git a/javascript/ql/test/query-tests/Security/CWE-079/ReflectedXss/ReflectedXss.expected b/javascript/ql/test/query-tests/Security/CWE-079/ReflectedXss/ReflectedXss.expected index 8ee7067977cd..5148f3f50a83 100644 --- a/javascript/ql/test/query-tests/Security/CWE-079/ReflectedXss/ReflectedXss.expected +++ b/javascript/ql/test/query-tests/Security/CWE-079/ReflectedXss/ReflectedXss.expected @@ -53,6 +53,11 @@ | partial.js:28:14:28:18 | x + y | partial.js:31:47:31:53 | req.url | partial.js:28:14:28:18 | x + y | Cross-site scripting vulnerability due to a $@. | partial.js:31:47:31:53 | req.url | user-provided value | | partial.js:37:14:37:18 | x + y | partial.js:40:43:40:49 | req.url | partial.js:37:14:37:18 | x + y | Cross-site scripting vulnerability due to a $@. | partial.js:40:43:40:49 | req.url | user-provided value | | promises.js:6:25:6:25 | x | promises.js:5:44:5:57 | req.query.data | promises.js:6:25:6:25 | x | Cross-site scripting vulnerability due to a $@. | promises.js:5:44:5:57 | req.query.data | user-provided value | +| replaceAll.js:23:12:23:53 | "

" + ... "

" | replaceAll.js:16:16:16:29 | req.query.name | replaceAll.js:23:12:23:53 | "

" + ... "

" | Cross-site scripting vulnerability due to a $@. | replaceAll.js:16:16:16:29 | req.query.name | user-provided value | +| replaceAll.js:24:12:24:57 | "

" + ... "

" | replaceAll.js:16:16:16:29 | req.query.name | replaceAll.js:24:12:24:57 | "

" + ... "

" | Cross-site scripting vulnerability due to a $@. | replaceAll.js:16:16:16:29 | req.query.name | user-provided value | +| replaceAll.js:25:12:25:59 | "

" + ... "

" | replaceAll.js:16:16:16:29 | req.query.name | replaceAll.js:25:12:25:59 | "

" + ... "

" | Cross-site scripting vulnerability due to a $@. | replaceAll.js:16:16:16:29 | req.query.name | user-provided value | +| replaceAll.js:28:12:28:69 | "

" + ... "

" | replaceAll.js:16:16:16:29 | req.query.name | replaceAll.js:28:12:28:69 | "

" + ... "

" | Cross-site scripting vulnerability due to a $@. | replaceAll.js:16:16:16:29 | req.query.name | user-provided value | +| replaceAll.js:29:12:29:67 | "

" + ... "

" | replaceAll.js:16:16:16:29 | req.query.name | replaceAll.js:29:12:29:67 | "

" + ... "

" | Cross-site scripting vulnerability due to a $@. | replaceAll.js:16:16:16:29 | req.query.name | user-provided value | | response-object.js:14:18:14:21 | data | response-object.js:7:18:7:25 | req.body | response-object.js:14:18:14:21 | data | Cross-site scripting vulnerability due to a $@. | response-object.js:7:18:7:25 | req.body | user-provided value | | response-object.js:17:18:17:21 | data | response-object.js:7:18:7:25 | req.body | response-object.js:17:18:17:21 | data | Cross-site scripting vulnerability due to a $@. | response-object.js:7:18:7:25 | req.body | user-provided value | | response-object.js:23:18:23:21 | data | response-object.js:7:18:7:25 | req.body | response-object.js:23:18:23:21 | data | Cross-site scripting vulnerability due to a $@. | response-object.js:7:18:7:25 | req.body | user-provided value | @@ -186,6 +191,22 @@ edges | promises.js:5:36:5:42 | [post update] resolve [resolve-value] | promises.js:5:16:5:22 | resolve [Return] [resolve-value] | provenance | | | promises.js:5:44:5:57 | req.query.data | promises.js:5:36:5:42 | [post update] resolve [resolve-value] | provenance | | | promises.js:6:11:6:11 | x | promises.js:6:25:6:25 | x | provenance | | +| replaceAll.js:16:9:16:12 | name | replaceAll.js:23:20:23:23 | name | provenance | | +| replaceAll.js:16:9:16:12 | name | replaceAll.js:24:20:24:23 | name | provenance | | +| replaceAll.js:16:9:16:12 | name | replaceAll.js:25:20:25:23 | name | provenance | | +| replaceAll.js:16:9:16:12 | name | replaceAll.js:28:20:28:23 | name | provenance | | +| replaceAll.js:16:9:16:12 | name | replaceAll.js:29:20:29:23 | name | provenance | | +| replaceAll.js:16:16:16:29 | req.query.name | replaceAll.js:16:9:16:12 | name | provenance | | +| replaceAll.js:23:20:23:23 | name | replaceAll.js:23:20:23:44 | name.re ... "<") | provenance | | +| replaceAll.js:23:20:23:44 | name.re ... "<") | replaceAll.js:23:12:23:53 | "

" + ... "

" | provenance | | +| replaceAll.js:24:20:24:23 | name | replaceAll.js:24:20:24:48 | name.re ... &") | provenance | | +| replaceAll.js:24:20:24:48 | name.re ... &") | replaceAll.js:24:12:24:57 | "

" + ... "

" | provenance | | +| replaceAll.js:25:20:25:23 | name | replaceAll.js:25:20:25:50 | name.re ... >", "") | provenance | | +| replaceAll.js:25:20:25:50 | name.re ... >", "") | replaceAll.js:25:12:25:59 | "

" + ... "

" | provenance | | +| replaceAll.js:28:20:28:23 | name | replaceAll.js:28:20:28:60 | name.re ... "<") | provenance | | +| replaceAll.js:28:20:28:60 | name.re ... "<") | replaceAll.js:28:12:28:69 | "

" + ... "

" | provenance | | +| replaceAll.js:29:20:29:23 | name | replaceAll.js:29:20:29:58 | name.re ... "<") | provenance | | +| replaceAll.js:29:20:29:58 | name.re ... "<") | replaceAll.js:29:12:29:67 | "

" + ... "

" | provenance | | | response-object.js:7:11:7:14 | data | response-object.js:14:18:14:21 | data | provenance | | | response-object.js:7:11:7:14 | data | response-object.js:17:18:17:21 | data | provenance | | | response-object.js:7:11:7:14 | data | response-object.js:23:18:23:21 | data | provenance | | @@ -415,6 +436,23 @@ nodes | promises.js:5:44:5:57 | req.query.data | semmle.label | req.query.data | | promises.js:6:11:6:11 | x | semmle.label | x | | promises.js:6:25:6:25 | x | semmle.label | x | +| replaceAll.js:16:9:16:12 | name | semmle.label | name | +| replaceAll.js:16:16:16:29 | req.query.name | semmle.label | req.query.name | +| replaceAll.js:23:12:23:53 | "

" + ... "

" | semmle.label | "

" + ... "

" | +| replaceAll.js:23:20:23:23 | name | semmle.label | name | +| replaceAll.js:23:20:23:44 | name.re ... "<") | semmle.label | name.re ... "<") | +| replaceAll.js:24:12:24:57 | "

" + ... "

" | semmle.label | "

" + ... "

" | +| replaceAll.js:24:20:24:23 | name | semmle.label | name | +| replaceAll.js:24:20:24:48 | name.re ... &") | semmle.label | name.re ... &") | +| replaceAll.js:25:12:25:59 | "

" + ... "

" | semmle.label | "

" + ... "

" | +| replaceAll.js:25:20:25:23 | name | semmle.label | name | +| replaceAll.js:25:20:25:50 | name.re ... >", "") | semmle.label | name.re ... >", "") | +| replaceAll.js:28:12:28:69 | "

" + ... "

" | semmle.label | "

" + ... "

" | +| replaceAll.js:28:20:28:23 | name | semmle.label | name | +| replaceAll.js:28:20:28:60 | name.re ... "<") | semmle.label | name.re ... "<") | +| replaceAll.js:29:12:29:67 | "

" + ... "

" | semmle.label | "

" + ... "

" | +| replaceAll.js:29:20:29:23 | name | semmle.label | name | +| replaceAll.js:29:20:29:58 | name.re ... "<") | semmle.label | name.re ... "<") | | response-object.js:7:11:7:14 | data | semmle.label | data | | response-object.js:7:18:7:25 | req.body | semmle.label | req.body | | response-object.js:14:18:14:21 | data | semmle.label | data | diff --git a/javascript/ql/test/query-tests/Security/CWE-079/ReflectedXss/ReflectedXssWithCustomSanitizer.expected b/javascript/ql/test/query-tests/Security/CWE-079/ReflectedXss/ReflectedXssWithCustomSanitizer.expected index a538fcd8ee70..7c7d961af804 100644 --- a/javascript/ql/test/query-tests/Security/CWE-079/ReflectedXss/ReflectedXssWithCustomSanitizer.expected +++ b/javascript/ql/test/query-tests/Security/CWE-079/ReflectedXss/ReflectedXssWithCustomSanitizer.expected @@ -51,6 +51,11 @@ | partial.js:28:14:28:18 | x + y | Cross-site scripting vulnerability due to $@. | partial.js:31:47:31:53 | req.url | user-provided value | | partial.js:37:14:37:18 | x + y | Cross-site scripting vulnerability due to $@. | partial.js:40:43:40:49 | req.url | user-provided value | | promises.js:6:25:6:25 | x | Cross-site scripting vulnerability due to $@. | promises.js:5:44:5:57 | req.query.data | user-provided value | +| replaceAll.js:23:12:23:53 | "

" + ... "

" | Cross-site scripting vulnerability due to $@. | replaceAll.js:16:16:16:29 | req.query.name | user-provided value | +| replaceAll.js:24:12:24:57 | "

" + ... "

" | Cross-site scripting vulnerability due to $@. | replaceAll.js:16:16:16:29 | req.query.name | user-provided value | +| replaceAll.js:25:12:25:59 | "

" + ... "

" | Cross-site scripting vulnerability due to $@. | replaceAll.js:16:16:16:29 | req.query.name | user-provided value | +| replaceAll.js:28:12:28:69 | "

" + ... "

" | Cross-site scripting vulnerability due to $@. | replaceAll.js:16:16:16:29 | req.query.name | user-provided value | +| replaceAll.js:29:12:29:67 | "

" + ... "

" | Cross-site scripting vulnerability due to $@. | replaceAll.js:16:16:16:29 | req.query.name | user-provided value | | response-object.js:14:18:14:21 | data | Cross-site scripting vulnerability due to $@. | response-object.js:7:18:7:25 | req.body | user-provided value | | response-object.js:17:18:17:21 | data | Cross-site scripting vulnerability due to $@. | response-object.js:7:18:7:25 | req.body | user-provided value | | response-object.js:23:18:23:21 | data | Cross-site scripting vulnerability due to $@. | response-object.js:7:18:7:25 | req.body | user-provided value | diff --git a/javascript/ql/test/query-tests/Security/CWE-079/ReflectedXss/replaceAll.js b/javascript/ql/test/query-tests/Security/CWE-079/ReflectedXss/replaceAll.js new file mode 100644 index 000000000000..7fbd762cd7cb --- /dev/null +++ b/javascript/ql/test/query-tests/Security/CWE-079/ReflectedXss/replaceAll.js @@ -0,0 +1,30 @@ +const express = require('express'); + +const app = express(); + +function escapeHtml(s) { + return s.replaceAll("&", "&").replaceAll("<", "<").replaceAll(">", ">"); +} + +function escapeQuotes(s) { + return s.replaceAll('"', """).replaceAll("'", "'"); +} + +const LT = "<"; + +app.get('/a', function (req, res) { + const name = req.query.name; // $ Source + + res.send("

" + escapeHtml(name) + "

"); + res.send("

" + name.replaceAll(/"); + res.send("

" + name.replaceAll(LT, "<") + "

"); + res.send('x'); + + res.send("

" + name.replace("<", "<") + "

"); // $ Alert - only replaces the first `<` + res.send("

" + name.replaceAll("&", "&") + "

"); // $ Alert - does not escape `<` + res.send("

" + name.replaceAll("