Repository navigation
Document Java server thread pool conventions - #19354
Open
JackieTien97 wants to merge 1 commit into
Open
JackieTien97 wants to merge 1 commit into
JackieTien97 wants to merge 1 commit into
Conversation
(cherry picked from commit d4fa00c)
|
5 tasks done
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19354 +/- ##
============================================
- Coverage 49.44% 49.43% -0.01%
Complexity 718 718
============================================
Files 5656 5656
Lines 418222 418222
Branches 55296 55296
============================================
- Hits 206769 206751 -18
- Misses 211453 211471 +18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
Document how Java server components can expose their thread pools through JMX and IoTDB metrics. The guidance covers choosing a factory or wrapped executor, naming pools, shutting them down with their owner, and enabling idle retirement when a workload needs it.
These conventions were discussed during review of #19344 and apply across server modules that use
node-commons.Verification
Checked the documented behavior against
IoTDBThreadPoolFactory,WrappedThreadPoolExecutor,ThreadName, andThreadPoolMetrics. The documentation diff passesgit diff --check.