Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 31 additions & 6 deletions sqlmodel/_compat.py
Original file line number Diff line number Diff line change
Expand Up @@ -342,13 +342,38 @@ def sqlmodel_init(*, self: "SQLModel", data: dict[str, Any]) -> None:
data,
self_instance=self,
)
else:
object.__setattr__(
self,
"__dict__",
{**old_dict, **self.__dict__},
)
elif not data:
sqlmodel_table_construct(
self_instance=self,
values=data,
)
object.__setattr__(
self,
"__dict__",
{**old_dict, **self.__dict__},
)
object.__setattr__(
self,
"__dict__",
{**old_dict, **self.__dict__},
)
else:
relationships: dict[str, Any] = {}
field_data: dict[str, Any] = {}
for key, value in data.items():
if key in self.__sqlmodel_relationships__:
relationships[key] = value
else:
field_data[key] = value
self.__class__.__pydantic_validator__.validate_python(
field_data,
self_instance=self,
)
fields_set = self.__pydantic_fields_set__.copy()
validated_dict = self.__dict__.copy()
object.__setattr__(self, "__dict__", old_dict)
for key, value in validated_dict.items():
setattr(self, key, value)
object.__setattr__(self, "__pydantic_fields_set__", fields_set)
for key, value in relationships.items():
setattr(self, key, value)
84 changes: 84 additions & 0 deletions tests/test_table_validation.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
import pytest
from pydantic import ValidationError
from sqlalchemy import Engine
from sqlmodel import Field, Relationship, Session, SQLModel, select


def test_table_model_validates_field_types():
class Hero(SQLModel, table=True):
id: int | None = Field(default=None, primary_key=True)
name: str
age: int

with pytest.raises(ValidationError) as exc_info:
Hero(name="Spider-Boy", age="not-an-integer")

errors = exc_info.value.errors()
assert len(errors) == 1
assert errors[0]["loc"] == ("age",)


def test_table_model_validates_field_constraints():
class Hero(SQLModel, table=True):
id: int | None = Field(default=None, primary_key=True)
name: str = Field(min_length=2, max_length=20)
power_level: int = Field(gt=0)

with pytest.raises(ValidationError):
Hero(name="A", power_level=10)

with pytest.raises(ValidationError):
Hero(name="Spider-Boy", power_level=-5)


def test_table_model_coerces_and_persists_in_db(database_engine: Engine):
class Hero(SQLModel, table=True):
id: int | None = Field(default=None, primary_key=True)
name: str
age: int

SQLModel.metadata.create_all(database_engine)
hero = Hero(name="Spider-Boy", age="25") # type: ignore[arg-type]
assert hero.age == 25
assert isinstance(hero.age, int)

with Session(database_engine) as session:
session.add(hero)
session.commit()
session.refresh(hero)
saved = session.exec(select(Hero)).one()

assert saved.id is not None
assert saved.name == "Spider-Boy"
assert saved.age == 25


def test_table_model_validates_with_relationships(database_engine: Engine):
class Team(SQLModel, table=True):
id: int | None = Field(default=None, primary_key=True)
name: str
heroes: list["Hero"] = Relationship(back_populates="team")

class Hero(SQLModel, table=True):
id: int | None = Field(default=None, primary_key=True)
name: str
age: int
team_id: int | None = Field(default=None, foreign_key="team.id")
team: Team | None = Relationship(back_populates="heroes")

SQLModel.metadata.create_all(database_engine)
team = Team(name="Preventers")

with pytest.raises(ValidationError):
Hero(name="Spider-Boy", age="invalid", team=team) # type: ignore[arg-type]

hero = Hero(name="Spider-Boy", age="21", team=team) # type: ignore[arg-type]
assert hero.age == 21
assert hero.team is team

with Session(database_engine) as session:
session.add(hero)
session.commit()
saved_hero = session.exec(select(Hero)).one()
assert saved_hero.team is not None
assert saved_hero.team.name == "Preventers"