Repository navigation
perf(ci): Cache integration test dependency installations - #26720
Draft
nicohrubec wants to merge 13 commits into
Draft
nicohrubec wants to merge 13 commits into
nicohrubec wants to merge 13 commits into
Conversation
Co-Authored-By: OpenAI Codex <codex@openai.com>
Co-Authored-By: OpenAI Codex <codex@openai.com>
Co-Authored-By: OpenAI Codex <codex@openai.com>
Co-Authored-By: OpenAI Codex <codex@openai.com>
Co-Authored-By: OpenAI Codex <codex@openai.com>
Co-Authored-By: OpenAI Codex <codex@openai.com>
Co-Authored-By: OpenAI Codex <codex@openai.com>
Co-Authored-By: OpenAI Codex <codex@openai.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5e9421a. Configure here.
Co-Authored-By: OpenAI Codex <codex@openai.com>
Co-Authored-By: OpenAI Codex <codex@openai.com>
Co-Authored-By: OpenAI Codex <codex@openai.com>
Co-Authored-By: OpenAI Codex <codex@openai.com>
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 7 not successful, 56 successful. See the run.
Successful checks
|
Co-Authored-By: OpenAI Codex <codex@openai.com>
Contributor
size-limit report 📦Compared: cce5e67 (PR test merge using develop at 5a39728) Against: 5a39728 (develop) · base run #67367 ✅ Baseline matches: this diff contains only this PR's changes.
|
nicohrubec
commented
Nov 21, 2026
| // before a retry gets a chance to run. | ||
| const NPM_INSTALL_TIMEOUT_MS = 60_000; | ||
|
|
||
| async function npmInstallWithRetry(cwd: string, deps: string[]): Promise<void> { |
Member
Author
There was a problem hiding this comment.
this method was just moved as is to this new file
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Reuse integration-test dependency installations through a daily GitHub cache. Each scenario receives its own copy of the installed dependencies; missing combinations install normally, and custom setup cases keep fresh installs.
Why
Avoid repeatedly resolving and installing identical dependencies. Cache keys separate runtime versions, architectures and shards, and include a source hash and UTC date to refresh floating dependencies daily. A daily cleanup deletes integration caches dated before the current UTC day, preventing old daily snapshots from accumulating.
Average per shard across six shards per runtime:
Installation work is summed across workers and overlaps; it is included in job time and is not a wall-time saving. Whole-job times include setup, cache restoration and cleanup, excluding queues and the shared build. Single-run measurements.
Original · cold cache · warm cache. Measurements are from integration-focused benchmark runs.