Repository navigation
fix(astro): Only inject the server release in builds - #26725
Draft
sentry-junior[bot] wants to merge 1 commit into
Draft
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
Outside a build, such as in `astro check` or `astro sync`, Vite's dev plugin container throws when the plugin reads `ModuleInfo.isEntry`. Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
Contributor
size-limit report 📦Compared: a8110d1 (PR test merge using develop at 5a39728) Against: 5a39728 (develop) · base run #67367 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsAll optional checks were successful. 2 successful. See the run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The server release plugin now runs only in Vite builds. This fixes
[vite] The "isEntry" property of ModuleInfo is not supported., which a user hit duringastro checkwith source map upload set up, even with the server SDK disabled.Why
The plugin is added for every Astro command except
dev, so it can run outside a build. ItstransformreadsModuleInfo.isEntry, which Vite's dev plugin container doesn't support and throws on. The release only matters in build output, so the plugin now usesapply: 'build'.sentry-astro-server-initalready skips non-builds for the same reason.Reported through user feedback with Astro 7,
@sentry/astro11.15.0, and Vite 8.via @BYK.
--
View Session [Sentry]