Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions javascript/ql/lib/change-notes/2026-11-20-shared-ssa.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: majorAnalysis
---
* JavaScript and TypeScript data flow now use the shared SSA implementation, including refinements and conservative captured-variable definitions. The existing public SSA APIs remain available as shared-backed adapters, and the separate JavaScript SSA computation has been removed. This improves barrier-guard handling across refinements and control-flow joins, reducing false positives when guarded and overwritten values merge, and orders post-update flow after call and assignment completion.
7 changes: 5 additions & 2 deletions javascript/ql/lib/semmle/javascript/GlobalAccessPaths.qll
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ module;

import javascript
private import semmle.javascript.dataflow.InferredTypes
private import semmle.javascript.dataflow.internal.DataFlowNode
private import semmle.javascript.dataflow.internal.FlowSteps as FlowSteps
private import semmle.javascript.internal.CachedStages

Expand Down Expand Up @@ -413,7 +414,8 @@ module AccessPath {
pragma[inline]
DataFlow::Node getAReferenceTo(Root root, string path) {
path = fromReference(result, root) and
not root.isGlobal()
not root.isGlobal() and
not result instanceof TSsaSynthReadNode
}

/**
Expand All @@ -436,7 +438,8 @@ module AccessPath {
overlay[caller?]
pragma[inline]
DataFlow::Node getAReferenceTo(string path) {
path = fromReference(result, DataFlow::globalAccessPathRootPseudoNode())
path = fromReference(result, DataFlow::globalAccessPathRootPseudoNode()) and
not result instanceof TSsaSynthReadNode
}

/**
Expand Down
Loading
Loading