Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* A `replaceAll` call whose string pattern is `<`, `'` or `"`, such as `s.replaceAll("<", "&lt;")`, is now recognized as a sanitizer by the cross-site scripting queries, such as `js/xss`, `js/reflected-xss` and `js/stored-xss`, in the same way as a global regular expression replacement.
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ module Shared {
abstract class Sanitizer extends DataFlow::Node { }

/**
* A global regexp replacement involving the `<`, `'`, or `"` meta-character, viewed as a sanitizer for
* A global replacement involving the `<`, `'`, or `"` meta-character, viewed as a sanitizer for
* XSS vulnerabilities.
*/
class MetacharEscapeSanitizer extends Sanitizer, StringReplaceCall {
Expand All @@ -42,6 +42,10 @@ module Shared {
or
// or it's like a wild-card.
RegExp::isWildcardLike(this.getRegExp().getRoot())
or
// or it's a `replaceAll` call whose string pattern is a meta-character.
this.getMethodName() = "replaceAll" and
forex(string s | this.getArgument(0).mayHaveStringValue(s) | s = ["<", "'", "\""])
)
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,11 @@
| partial.js:28:14:28:18 | x + y | partial.js:31:47:31:53 | req.url | partial.js:28:14:28:18 | x + y | Cross-site scripting vulnerability due to a $@. | partial.js:31:47:31:53 | req.url | user-provided value |
| partial.js:37:14:37:18 | x + y | partial.js:40:43:40:49 | req.url | partial.js:37:14:37:18 | x + y | Cross-site scripting vulnerability due to a $@. | partial.js:40:43:40:49 | req.url | user-provided value |
| promises.js:6:25:6:25 | x | promises.js:5:44:5:57 | req.query.data | promises.js:6:25:6:25 | x | Cross-site scripting vulnerability due to a $@. | promises.js:5:44:5:57 | req.query.data | user-provided value |
| replaceAll.js:23:12:23:53 | "<p>" + ... "</p>" | replaceAll.js:16:16:16:29 | req.query.name | replaceAll.js:23:12:23:53 | "<p>" + ... "</p>" | Cross-site scripting vulnerability due to a $@. | replaceAll.js:16:16:16:29 | req.query.name | user-provided value |
| replaceAll.js:24:12:24:57 | "<p>" + ... "</p>" | replaceAll.js:16:16:16:29 | req.query.name | replaceAll.js:24:12:24:57 | "<p>" + ... "</p>" | Cross-site scripting vulnerability due to a $@. | replaceAll.js:16:16:16:29 | req.query.name | user-provided value |
| replaceAll.js:25:12:25:59 | "<p>" + ... "</p>" | replaceAll.js:16:16:16:29 | req.query.name | replaceAll.js:25:12:25:59 | "<p>" + ... "</p>" | Cross-site scripting vulnerability due to a $@. | replaceAll.js:16:16:16:29 | req.query.name | user-provided value |
| replaceAll.js:28:12:28:69 | "<p>" + ... "</p>" | replaceAll.js:16:16:16:29 | req.query.name | replaceAll.js:28:12:28:69 | "<p>" + ... "</p>" | Cross-site scripting vulnerability due to a $@. | replaceAll.js:16:16:16:29 | req.query.name | user-provided value |
| replaceAll.js:29:12:29:67 | "<p>" + ... "</p>" | replaceAll.js:16:16:16:29 | req.query.name | replaceAll.js:29:12:29:67 | "<p>" + ... "</p>" | Cross-site scripting vulnerability due to a $@. | replaceAll.js:16:16:16:29 | req.query.name | user-provided value |
| response-object.js:14:18:14:21 | data | response-object.js:7:18:7:25 | req.body | response-object.js:14:18:14:21 | data | Cross-site scripting vulnerability due to a $@. | response-object.js:7:18:7:25 | req.body | user-provided value |
| response-object.js:17:18:17:21 | data | response-object.js:7:18:7:25 | req.body | response-object.js:17:18:17:21 | data | Cross-site scripting vulnerability due to a $@. | response-object.js:7:18:7:25 | req.body | user-provided value |
| response-object.js:23:18:23:21 | data | response-object.js:7:18:7:25 | req.body | response-object.js:23:18:23:21 | data | Cross-site scripting vulnerability due to a $@. | response-object.js:7:18:7:25 | req.body | user-provided value |
Expand Down Expand Up @@ -186,6 +191,22 @@ edges
| promises.js:5:36:5:42 | [post update] resolve [resolve-value] | promises.js:5:16:5:22 | resolve [Return] [resolve-value] | provenance | |
| promises.js:5:44:5:57 | req.query.data | promises.js:5:36:5:42 | [post update] resolve [resolve-value] | provenance | |
| promises.js:6:11:6:11 | x | promises.js:6:25:6:25 | x | provenance | |
| replaceAll.js:16:9:16:12 | name | replaceAll.js:23:20:23:23 | name | provenance | |
| replaceAll.js:16:9:16:12 | name | replaceAll.js:24:20:24:23 | name | provenance | |
| replaceAll.js:16:9:16:12 | name | replaceAll.js:25:20:25:23 | name | provenance | |
| replaceAll.js:16:9:16:12 | name | replaceAll.js:28:20:28:23 | name | provenance | |
| replaceAll.js:16:9:16:12 | name | replaceAll.js:29:20:29:23 | name | provenance | |
| replaceAll.js:16:16:16:29 | req.query.name | replaceAll.js:16:9:16:12 | name | provenance | |
| replaceAll.js:23:20:23:23 | name | replaceAll.js:23:20:23:44 | name.re ... "&lt;") | provenance | |
| replaceAll.js:23:20:23:44 | name.re ... "&lt;") | replaceAll.js:23:12:23:53 | "<p>" + ... "</p>" | provenance | |
| replaceAll.js:24:20:24:23 | name | replaceAll.js:24:20:24:48 | name.re ... &amp;") | provenance | |
| replaceAll.js:24:20:24:48 | name.re ... &amp;") | replaceAll.js:24:12:24:57 | "<p>" + ... "</p>" | provenance | |
| replaceAll.js:25:20:25:23 | name | replaceAll.js:25:20:25:50 | name.re ... >", "") | provenance | |
| replaceAll.js:25:20:25:50 | name.re ... >", "") | replaceAll.js:25:12:25:59 | "<p>" + ... "</p>" | provenance | |
| replaceAll.js:28:20:28:23 | name | replaceAll.js:28:20:28:60 | name.re ... "&lt;") | provenance | |
| replaceAll.js:28:20:28:60 | name.re ... "&lt;") | replaceAll.js:28:12:28:69 | "<p>" + ... "</p>" | provenance | |
| replaceAll.js:29:20:29:23 | name | replaceAll.js:29:20:29:58 | name.re ... "&lt;") | provenance | |
| replaceAll.js:29:20:29:58 | name.re ... "&lt;") | replaceAll.js:29:12:29:67 | "<p>" + ... "</p>" | provenance | |
| response-object.js:7:11:7:14 | data | response-object.js:14:18:14:21 | data | provenance | |
| response-object.js:7:11:7:14 | data | response-object.js:17:18:17:21 | data | provenance | |
| response-object.js:7:11:7:14 | data | response-object.js:23:18:23:21 | data | provenance | |
Expand Down Expand Up @@ -415,6 +436,23 @@ nodes
| promises.js:5:44:5:57 | req.query.data | semmle.label | req.query.data |
| promises.js:6:11:6:11 | x | semmle.label | x |
| promises.js:6:25:6:25 | x | semmle.label | x |
| replaceAll.js:16:9:16:12 | name | semmle.label | name |
| replaceAll.js:16:16:16:29 | req.query.name | semmle.label | req.query.name |
| replaceAll.js:23:12:23:53 | "<p>" + ... "</p>" | semmle.label | "<p>" + ... "</p>" |
| replaceAll.js:23:20:23:23 | name | semmle.label | name |
| replaceAll.js:23:20:23:44 | name.re ... "&lt;") | semmle.label | name.re ... "&lt;") |
| replaceAll.js:24:12:24:57 | "<p>" + ... "</p>" | semmle.label | "<p>" + ... "</p>" |
| replaceAll.js:24:20:24:23 | name | semmle.label | name |
| replaceAll.js:24:20:24:48 | name.re ... &amp;") | semmle.label | name.re ... &amp;") |
| replaceAll.js:25:12:25:59 | "<p>" + ... "</p>" | semmle.label | "<p>" + ... "</p>" |
| replaceAll.js:25:20:25:23 | name | semmle.label | name |
| replaceAll.js:25:20:25:50 | name.re ... >", "") | semmle.label | name.re ... >", "") |
| replaceAll.js:28:12:28:69 | "<p>" + ... "</p>" | semmle.label | "<p>" + ... "</p>" |
| replaceAll.js:28:20:28:23 | name | semmle.label | name |
| replaceAll.js:28:20:28:60 | name.re ... "&lt;") | semmle.label | name.re ... "&lt;") |
| replaceAll.js:29:12:29:67 | "<p>" + ... "</p>" | semmle.label | "<p>" + ... "</p>" |
| replaceAll.js:29:20:29:23 | name | semmle.label | name |
| replaceAll.js:29:20:29:58 | name.re ... "&lt;") | semmle.label | name.re ... "&lt;") |
| response-object.js:7:11:7:14 | data | semmle.label | data |
| response-object.js:7:18:7:25 | req.body | semmle.label | req.body |
| response-object.js:14:18:14:21 | data | semmle.label | data |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,11 @@
| partial.js:28:14:28:18 | x + y | Cross-site scripting vulnerability due to $@. | partial.js:31:47:31:53 | req.url | user-provided value |
| partial.js:37:14:37:18 | x + y | Cross-site scripting vulnerability due to $@. | partial.js:40:43:40:49 | req.url | user-provided value |
| promises.js:6:25:6:25 | x | Cross-site scripting vulnerability due to $@. | promises.js:5:44:5:57 | req.query.data | user-provided value |
| replaceAll.js:23:12:23:53 | "<p>" + ... "</p>" | Cross-site scripting vulnerability due to $@. | replaceAll.js:16:16:16:29 | req.query.name | user-provided value |
| replaceAll.js:24:12:24:57 | "<p>" + ... "</p>" | Cross-site scripting vulnerability due to $@. | replaceAll.js:16:16:16:29 | req.query.name | user-provided value |
| replaceAll.js:25:12:25:59 | "<p>" + ... "</p>" | Cross-site scripting vulnerability due to $@. | replaceAll.js:16:16:16:29 | req.query.name | user-provided value |
| replaceAll.js:28:12:28:69 | "<p>" + ... "</p>" | Cross-site scripting vulnerability due to $@. | replaceAll.js:16:16:16:29 | req.query.name | user-provided value |
| replaceAll.js:29:12:29:67 | "<p>" + ... "</p>" | Cross-site scripting vulnerability due to $@. | replaceAll.js:16:16:16:29 | req.query.name | user-provided value |
| response-object.js:14:18:14:21 | data | Cross-site scripting vulnerability due to $@. | response-object.js:7:18:7:25 | req.body | user-provided value |
| response-object.js:17:18:17:21 | data | Cross-site scripting vulnerability due to $@. | response-object.js:7:18:7:25 | req.body | user-provided value |
| response-object.js:23:18:23:21 | data | Cross-site scripting vulnerability due to $@. | response-object.js:7:18:7:25 | req.body | user-provided value |
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
const express = require('express');

const app = express();

function escapeHtml(s) {
return s.replaceAll("&", "&amp;").replaceAll("<", "&lt;").replaceAll(">", "&gt;");
}

function escapeQuotes(s) {
return s.replaceAll('"', "&quot;").replaceAll("'", "&#39;");
}

const LT = "<";

app.get('/a', function (req, res) {
const name = req.query.name; // $ Source

res.send("<p>" + escapeHtml(name) + "</p>");
res.send("<p>" + name.replaceAll(/</g, "&lt;") + "</p>");
res.send("<p>" + name.replaceAll(LT, "&lt;") + "</p>");
res.send('<a title="' + escapeQuotes(name) + '">x</a>');

res.send("<p>" + name.replace("<", "&lt;") + "</p>"); // $ Alert - only replaces the first `<`
res.send("<p>" + name.replaceAll("&", "&amp;") + "</p>"); // $ Alert - does not escape `<`
res.send("<p>" + name.replaceAll("<script>", "") + "</p>"); // $ Alert - not a meta-character

const flag = Math.random() > 0.5;
res.send("<p>" + name.replaceAll(flag ? "<" : "x", "&lt;") + "</p>"); // $ Alert - may not escape `<`
res.send("<p>" + name.replace(flag ? /x/g : "<", "&lt;") + "</p>"); // $ Alert - neither pattern escapes every `<`
});