Skip to content

Bump vscode-languageclient from 8.1.0 to 11.0.0 in /extensions/ql-vscode - #4630

Merged
cklin merged 4 commits into
mainfrom
dependabot/npm_and_yarn/extensions/ql-vscode/vscode-languageclient-11.0.0
Nov 20, 2026
Merged

cklin merged 4 commits into
mainfrom
dependabot/npm_and_yarn/extensions/ql-vscode/vscode-languageclient-11.0.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 29, 2026

Copy link
Copy Markdown
Contributor

Bumps vscode-languageclient from 8.1.0 to 11.0.0.

Release notes

Sourced from vscode-languageclient's releases.

release/client/11.0.0

No release notes provided.

release/server/11.0.0

No release notes provided.

release/client/10.1.2

No release notes provided.

release/server/10.1.2

No release notes provided.

release/client/10.1.1

No release notes provided.

release/server/10.1.1

No release notes provided.

release/client/10.1.0

No release notes provided.

release/server/10.1.0

No release notes provided.

release/client/10.0.1

No release notes provided.

release/server/10.0.1

No release notes provided.

release/client/10.0.0

Changes:

  • #1786: Shorten test dir path

This list of changes was auto generated.

release/server/10.0.0

No release notes provided.

release/jsonrpc/10.0.0

No release notes provided.

release/client/10.0.0-next.22

No release notes provided.

release/client/10.0.0-next.21

No release notes provided.

... (truncated)

Commits
  • c2916c2 Prepare new release
  • 4932870 Merge pull request #1896 from lagergren/fix/stop-after-failed-initialize
  • 6687d48 Merge pull request #1897 from reginaldalfret/fix/reginald-lsp-watcher-duplica...
  • 665ad43 Merge pull request #1782 from lionel-/bugfix/lsp-close-race
  • af95dac Merge branch 'main' into fix/stop-after-failed-initialize
  • d111de6 Merge branch 'main' into fix/reginald-lsp-watcher-duplicate-id-leak
  • 509f696 Clear pull state when a document diagnostic pull fails (#1899)
  • 827668c Don't rely on Promise.prototype.finally when starting or stopping the client ...
  • b566bfd Handle the stop that follows a failed initialization
  • bb2e960 client: remove @​types/minimatch (#1884)
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by microsoft1es, a new releaser for vscode-languageclient since your current version.


Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
vscode-languageclient [>= 9.a, < 10]

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [vscode-languageclient](https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client) from 8.1.0 to 11.0.0.
- [Release notes](https://github.com/Microsoft/vscode-languageserver-node/releases)
- [Commits](https://github.com/Microsoft/vscode-languageserver-node/commits/release/client/11.0.0/client)

---
updated-dependencies:
- dependency-name: vscode-languageclient
  dependency-version: 11.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added the Update dependencies Dependabot update PRs label Oct 29, 2026
@dependabot
dependabot Bot requested a review from a team as a code owner October 29, 2026 13:14
@codeql-ci-app

codeql-ci-app Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Dependabot automation

Retrying failed jobs once before Copilot investigation. If CI passes, this pristine PR remains eligible for automatic merging.

Automation run

@github-actions github-actions Bot added the dependency-needs-review Dependabot automation state; remove only deliberately label Oct 30, 2026
@codeql-ci-app

codeql-ci-app Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Dependabot automation

Diagnosis: The vscode-languageclient upgrade from 8.1.0 to 11.0.0 changes the supplied output channel type from OutputChannel to LogOutputChannel. In Build Extension run 40880068869, attempt 2, the Ubuntu build and test jobs and both CLI Test jobs failed during build with TS2740 at language-client.ts:41; Lint failed its type check with the same error. The Windows Build and Test jobs were cancelled; their integration results are unknown.

Why maintainer action is needed: The existing channel also receives raw language-server stdout and stderr with trailingNewline: false. Simply switching it to a log channel changes that behavior: VS Code 1.101's implementation routes each append through info-level logging, with formatting and filtering. Client 11 also gates protocol tracing on the channel's Trace log level, unlike client 8.1. The upstream 11.0.0 release history confirms the breaking channel change. A type-only fix would therefore risk changing or losing diagnostic output.

Please choose whether to accept the new logging semantics, separate raw process output from client logs, or implement and test a compatible adapter. Verify logging, tracing, disposal, and language-server integration on Linux and Windows before merging. Human review and merge are required even if CI subsequently passes.

No checkout files were changed. Locally, npm ci succeeded with Node 22.21.1 engine warnings; npm run check-types reproduced TS2740. Other tests, including Windows and CodeQL integration, were not run. Web search was unavailable; the versioned upstream sources above were fetched directly.

Automatic merging is blocked pending a maintainer decision.

Automation run

@cklin cklin removed the dependency-needs-review Dependabot automation state; remove only deliberately label Oct 30, 2026
@github-actions github-actions Bot added the dependency-needs-review Dependabot automation state; remove only deliberately label Oct 30, 2026
@codeql-ci-app

This comment was marked as duplicate.

Let vscode-languageclient 11 manage its native log channel while
preserving raw language-server output in the existing channel.

Document the new channel and the log level needed for tracing.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0757eb7c-b8a7-4586-af2f-9fd2c88ffbc2
Copilot AI adaptive review requested due to automatic review settings November 20, 2026 15:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

A critical active finding remains because the dependency chain resolves to vulnerable minimatch@10.2.6, which requires updating to a patched version.

1 open issue
1 file not reviewed
  • extensions/ql-vscode/package-lock.json: Generated file
What changed in this PR

Updates the CodeQL VS Code extension to use vscode-languageclient 11.0.0 and separates language-client diagnostics and protocol traces from raw language-server output.

Changes:

  • Upgrades vscode-languageclient and related protocol dependencies.
  • Configures a dedicated CodeQL Language Client output channel.
  • Documents the updated logging and tracing behavior.
File Description
extensions/​ql-vscode/​src/​language-support/​language-client.ts Routes language-client logs and protocol traces to a dedicated output channel.
extensions/​ql-vscode/​package.json Bumps the vscode-languageclient dependency to 11.0.0.
extensions/​ql-vscode/​package-lock.json Locks the upgraded language client and updated transitive protocol dependencies.
extensions/​ql-vscode/​CHANGELOG.md Documents the separate language-client and language-server logging behavior.

Review effort: Lite (adaptive)

Comment thread extensions/ql-vscode/package.json Resolved
cklin and others added 2 commits November 20, 2026 07:38
Scope the override to vscode-languageclient to address
GHSA-g3hv-75wg-m249 without changing other minimatch consumers.

Update the lockfile with the patched version and its dependency.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0757eb7c-b8a7-4586-af2f-9fd2c88ffbc2
Reject non-public registry URLs, credentials, and insecure schemes
with a dependency-free Node script.

Run the check after lockfile formatting in lint-staged and before
installing dependencies in CI. Cover accepted and rejected URLs
with focused tests.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0757eb7c-b8a7-4586-af2f-9fd2c88ffbc2
@cklin
cklin force-pushed the dependabot/npm_and_yarn/extensions/ql-vscode/vscode-languageclient-11.0.0 branch from 79ccf8e to 1e19fc0 Compare November 20, 2026 16:39
@cklin
cklin merged commit ae5d096 into main Nov 20, 2026
34 checks passed
@cklin
cklin deleted the dependabot/npm_and_yarn/extensions/ql-vscode/vscode-languageclient-11.0.0 branch November 20, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependency-needs-review Dependabot automation state; remove only deliberately Update dependencies Dependabot update PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants