Repository navigation
Bump vscode-languageclient from 8.1.0 to 11.0.0 in /extensions/ql-vscode - #4630
Conversation
Bumps [vscode-languageclient](https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/client) from 8.1.0 to 11.0.0. - [Release notes](https://github.com/Microsoft/vscode-languageserver-node/releases) - [Commits](https://github.com/Microsoft/vscode-languageserver-node/commits/release/client/11.0.0/client) --- updated-dependencies: - dependency-name: vscode-languageclient dependency-version: 11.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Dependabot automationRetrying failed jobs once before Copilot investigation. If CI passes, this pristine PR remains eligible for automatic merging. |
Dependabot automationDiagnosis: The Why maintainer action is needed: The existing channel also receives raw language-server stdout and stderr with Please choose whether to accept the new logging semantics, separate raw process output from client logs, or implement and test a compatible adapter. Verify logging, tracing, disposal, and language-server integration on Linux and Windows before merging. Human review and merge are required even if CI subsequently passes. No checkout files were changed. Locally, Automatic merging is blocked pending a maintainer decision. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Let vscode-languageclient 11 manage its native log channel while preserving raw language-server output in the existing channel. Document the new channel and the log level needed for tracing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0757eb7c-b8a7-4586-af2f-9fd2c88ffbc2
There was a problem hiding this comment.
🟡 Changes recommended
A critical active finding remains because the dependency chain resolves to vulnerable minimatch@10.2.6, which requires updating to a patched version.
1 open issue
1 file not reviewed
extensions/ql-vscode/package-lock.json: Generated file
What changed in this PR
Updates the CodeQL VS Code extension to use vscode-languageclient 11.0.0 and separates language-client diagnostics and protocol traces from raw language-server output.
Changes:
- Upgrades vscode-languageclient and related protocol dependencies.
- Configures a dedicated CodeQL Language Client output channel.
- Documents the updated logging and tracing behavior.
| File | Description |
|---|---|
| extensions/ql-vscode/src/language-support/language-client.ts | Routes language-client logs and protocol traces to a dedicated output channel. |
| extensions/ql-vscode/package.json | Bumps the vscode-languageclient dependency to 11.0.0. |
| extensions/ql-vscode/package-lock.json | Locks the upgraded language client and updated transitive protocol dependencies. |
| extensions/ql-vscode/CHANGELOG.md | Documents the separate language-client and language-server logging behavior. |
Review effort: Lite (adaptive)
Scope the override to vscode-languageclient to address GHSA-g3hv-75wg-m249 without changing other minimatch consumers. Update the lockfile with the patched version and its dependency. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0757eb7c-b8a7-4586-af2f-9fd2c88ffbc2
Reject non-public registry URLs, credentials, and insecure schemes with a dependency-free Node script. Run the check after lockfile formatting in lint-staged and before installing dependencies in CI. Cover accepted and rejected URLs with focused tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0757eb7c-b8a7-4586-af2f-9fd2c88ffbc2
79ccf8e to
1e19fc0
Compare

Bumps vscode-languageclient from 8.1.0 to 11.0.0.
Release notes
Sourced from vscode-languageclient's releases.
... (truncated)
Commits
c2916c2Prepare new release4932870Merge pull request #1896 from lagergren/fix/stop-after-failed-initialize6687d48Merge pull request #1897 from reginaldalfret/fix/reginald-lsp-watcher-duplica...665ad43Merge pull request #1782 from lionel-/bugfix/lsp-close-raceaf95dacMerge branch 'main' into fix/stop-after-failed-initialized111de6Merge branch 'main' into fix/reginald-lsp-watcher-duplicate-id-leak509f696Clear pull state when a document diagnostic pull fails (#1899)827668cDon't rely on Promise.prototype.finally when starting or stopping the client ...b566bfdHandle the stop that follows a failed initializationbb2e960client: remove@types/minimatch(#1884)Maintainer changes
This version was pushed to npm by microsoft1es, a new releaser for vscode-languageclient since your current version.
Most Recent Ignore Conditions Applied to This Pull Request
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)