Skip to content

Fix Punycode conversion and harden validations - #194

Merged
m13253 merged 1 commit into
masterfrom
fix/idna-conversion
Nov 22, 2026
Merged

m13253 merged 1 commit into
masterfrom
fix/idna-conversion

Conversation

@m13253

@m13253 m13253 commented Nov 22, 2026

Copy link
Copy Markdown
Owner
  • Subdomain check now uses the more robust dns.IsSubDomain function.
  • Invalid domain names in the configuration item passthrough are now rejected upon program launch. The root domain . and overlong names are also rejected. They were silently ignored before.
  • Corrected two inverted err != nil to err == nil so the Punycode conversion actually happens.
  • Check domain name length before calling Punycode conversion to improve efficiency.

- Subdomain check now uses the more robust dns.IsSubDomain function.
- Invalid domain names in the configuration item "passthrough" are now rejected upon program launch. The root domain "." and overlong names are also rejected. They were silently ignored before.
- Corrected two inverted "err != nil" to "err == nil" so the Punycode conversion actually happens.
- Check domain name length before calling Punycode conversion to improve efficiency.
@m13253
m13253 merged commit 6440815 into master Nov 22, 2026
5 checks passed
@m13253
m13253 deleted the fix/idna-conversion branch November 22, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant