Repository navigation
Fix Punycode conversion and harden validations - #194
Merged
Merged
Conversation
- Subdomain check now uses the more robust dns.IsSubDomain function. - Invalid domain names in the configuration item "passthrough" are now rejected upon program launch. The root domain "." and overlong names are also rejected. They were silently ignored before. - Corrected two inverted "err != nil" to "err == nil" so the Punycode conversion actually happens. - Check domain name length before calling Punycode conversion to improve efficiency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dns.IsSubDomainfunction.passthroughare now rejected upon program launch. The root domain.and overlong names are also rejected. They were silently ignored before.err != niltoerr == nilso the Punycode conversion actually happens.