Skip to content

test(clion): the settings run reads the settled text, and a plugin change runs the real IDEs - #20

Merged
Sunrisepeak merged 2 commits into
mainfrom
test/clion-settings-typed-value
Nov 21, 2026
Merged

Sunrisepeak merged 2 commits into
mainfrom
test/clion-settings-typed-value

Conversation

@Sunrisepeak

@Sunrisepeak Sunrisepeak commented Nov 21, 2026 •

Copy link
Copy Markdown
Member

Summary

main's CI after 1.6.0 (run 44901645534) failed SettingsInteractionTest on CLion 2026.2.4.1, Linux x86_64,
at "the real input receives the typed value". The run read the input's text as the last key was posted,
before the EDT had handled the keys, and typed while the request to focus the input could still be queued.
It now waits until the input owns the focus before typing and reads the text once it has settled, ten
seconds at most for each. The plugin is unchanged.

The pull request's first CI run skipped clion-stable: it needed clion with the default condition, and a
change of the plugin alone skips the backend's jobs, which clion follows; the skip reached clion-stable.
It now runs whenever clion succeeded, so a change of the plugin alone is run in the real IDEs too.

Triage

The real-IDE test's own race (keyboard events are handled after they are posted); n/a to the plugin and the backend.

Criteria

  • The settings run passed twice in CLion 2026.2.4.1 with the released mcpp-clion 1.6.0 ZIP, locally (Linux x86_64, Xvfb).
  • clion-stable in this pull request's CI.

Compatibility

Tests and CI only.

Checklist

  • One thing; the title is <type>(<component>): <sentence>.
  • No behaviour changes; no docs, schema or strings affected.
  • spec/ untouched.
  • No commit carries an attribution trailer.

…reads the settled text

main's run after 1.6.0 failed the settings dialog's check that the input
receives the typed value on CLion 2026.2.4.1 (Linux x86_64): the text was
read as the last key was posted, before the EDT had handled the keys, and the
keys went to whatever had the focus when the request to focus was still
queued. The run now waits until the input owns the focus before typing, and
reads the text once it has settled, within ten seconds each.
clion-stable needed clion alone with the default condition, and a change
of the plugin alone skips the backend's jobs, which clion follows; the skip
reached clion-stable, so such a change never ran the real IDE. It now runs
whenever clion succeeded.
@Sunrisepeak Sunrisepeak changed the title test(clion): the settings run types once the input has the focus and reads the settled text test(clion): the settings run reads the settled text, and a plugin change runs the real IDEs Nov 21, 2026
@Sunrisepeak
Sunrisepeak merged commit fcbbfed into main Nov 21, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant