Skip to content

fix(release): stop when changelog-maker has no GitHub token - #1251

Closed
GroophyLifefor wants to merge 1 commit into
nodejs:mainfrom
GroophyLifefor:murat-fix-changelog-maker-token
Closed

GroophyLifefor wants to merge 1 commit into
nodejs:mainfrom
GroophyLifefor:murat-fix-changelog-maker-token

Conversation

@GroophyLifefor

Copy link
Copy Markdown

Fixes: #1250

Without a stored GitHub token, changelog-maker prints an auth prompt and exits with status 0, so git node release --prepare wrote the prompt into the changelog. getChangelog() now throws when the output contains the prompt, with a hint to run changelog-maker once in a terminal to store a token.

Verified locally: unit tests pass (781/781), eslint clean, and a run with no changelog-maker token now throws the new error instead of returning the prompt.

AI-assisted; reviewed by a human.

Without a stored GitHub token, changelog-maker prints an auth prompt on
stdout and exits with status 0, and the prompt was written into the
release changelog. Throw a clear error instead.

Fixes: nodejs#1250
Assisted-by: a closed-source coding agent
Signed-off-by: Murat Kirazkaya <groophylifefor@gmail.com>
@GroophyLifefor
GroophyLifefor marked this pull request as ready for review November 20, 2026 14:34
@aduh95

aduh95 commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

It's a changelog-maker issue

@aduh95 aduh95 closed this Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

git node release --prepare writes changelog-maker's token prompt into the changelog

2 participants