Repository navigation
fix(release): stop when changelog-maker has no GitHub token - #1251
Closed
GroophyLifefor wants to merge 1 commit into
Closed
GroophyLifefor wants to merge 1 commit into
GroophyLifefor wants to merge 1 commit into
Conversation
Without a stored GitHub token, changelog-maker prints an auth prompt on stdout and exits with status 0, and the prompt was written into the release changelog. Throw a clear error instead. Fixes: nodejs#1250 Assisted-by: a closed-source coding agent Signed-off-by: Murat Kirazkaya <groophylifefor@gmail.com>
GroophyLifefor
marked this pull request as ready for review
November 20, 2026 14:34
Contributor
|
It's a changelog-maker issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1250
Without a stored GitHub token, changelog-maker prints an auth prompt and exits with status 0, so
git node release --preparewrote the prompt into the changelog.getChangelog()now throws when the output contains the prompt, with a hint to run changelog-maker once in a terminal to store a token.Verified locally: unit tests pass (781/781), eslint clean, and a run with no changelog-maker token now throws the new error instead of returning the prompt.
AI-assisted; reviewed by a human.