Repository navigation
Conversation
`DOMException` is a native error whose name and message are kept in internal state, so V8's built-in error serialization turned it into a plain `Error` with an empty message when using `v8.serialize()`. `structuredClone()` already handled it via the host object delegate. Let `DefaultSerializer` treat cloneable native errors as host objects and serialize them following the WebIDL `DOMException` serialization steps (name, message, stack, plus quota/requested for `QuotaExceededError`), carrying the same data as `structuredClone()`. Plain `v8.Serializer` instances keep their previous behavior. Fixes: nodejs#53225 Assisted-by: Claude Opus 5.5 Signed-off-by: jazelly <xzha4350@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #53225
v8.serialize()turns aDOMExceptioninto a plainErrorwith an emptymessage.structuredClone()already handles it.SerializerContextnow implementsIsHostObject(), soDefaultSerializerwrites cloneableDOMExceptions using the existing clone hooks (same data asstructuredClone()). Plainv8.Serializeris unchanged.child_processwithserialization: 'advanced'usesnode_ipc_serdes.ccand is not covered here.