Repository navigation
Conversation
ndossche
reviewed
Apr 4, 2026
ndossche
left a comment
Member
There was a problem hiding this comment.
It doesn't work because you need a result var. Furthermore the op handler destroys OP1 after setting the result, so they can't use the same TMP
Girgias
force-pushed
the
optimize-zend-verify-return-type
branch
from
April 10, 2026 13:36
784d394 to
3da764c
Compare
Member
Author
|
Attempting a new approach suggested by Arnaud to instead use VM specializations. I might revert the string one and just have a generic one as it's getting kinda complicated... |
Girgias
force-pushed
the
optimize-zend-verify-return-type
branch
7 times, most recently
from
April 10, 2026 19:15
82ad073 to
6cf5401
Compare
AWS x86_64 (c6id.metal)
Laravel 12.11.0 demo app - 50 iterations, 50 warmups, 100 requests (sec)
Symfony 2.8.0 demo app - 50 iterations, 50 warmups, 100 requests (sec)
Wordpress 6.9 main page - 50 iterations, 20 warmups, 20 requests (sec)
bench.php - 50 iterations, 20 warmups, 2 requests (sec)
|
AWS x86_64 (c6id.metal)
Laravel 12.11.0 demo app - 50 iterations, 50 warmups, 100 requests (sec)
Symfony 2.8.0 demo app - 50 iterations, 50 warmups, 100 requests (sec)
Wordpress 6.9 main page - 50 iterations, 20 warmups, 20 requests (sec)
bench.php - 50 iterations, 20 warmups, 2 requests (sec)
|
AWS x86_64 (c6id.metal)
Laravel 12.11.0 demo app - 50 iterations, 50 warmups, 100 requests (sec)
Symfony 2.8.0 demo app - 50 iterations, 50 warmups, 100 requests (sec)
Wordpress 6.9 main page - 50 iterations, 20 warmups, 20 requests (sec)
bench.php - 50 iterations, 20 warmups, 2 requests (sec)
|
…e type" This reverts commit 819153bbf39502141432e7a2eaed5e19d775d912.
This reverts commit 6cf5401ad9741025685f735d542fac718423d33e. This is quite complex and I wonder if a generic one would be better
This reverts commit 20d2b6e5c506977dbdb367a71b6c1bf776ebe556. Because it turns out this has massive performance implications.
…ues" This reverts commit e16b2b9.
This reverts commit b61b5d9.
Girgias
force-pushed
the
optimize-zend-verify-return-type
branch
from
May 12, 2026 22:56
64fb060 to
b0501cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came up with this idea while working on #21580,
but no idea if this is a safe way to write an optimizationclearly not because it seems to segfault everything.