Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-25645
Since traits are bound before the parent class,
ce->parentstill holds the parent name while trait constants and properties are bound. When a value has to be evaluated to check it against a second definition,parentreads that string as a class entry and crashes.zend_do_link_class()already has the parent class entry at that point, so I resolvece->parentbefore binding the traits.zend_do_inheritance_ex()then skips releasingparent_namewhen the parent is already resolved.The
self::Acase from the issue does not crash and still fails the same way, since the parent constants are not inherited yet at that point. I left it out of this PR.