Repository navigation
gh-95723: setup InternalDocs/fractions.md - #160625
skirpichev wants to merge 6 commits into
Conversation
This includes correctness proof of Fraction.limit_denominator by Mark Dickinson.
|
CC @mdickinson |
|
FYI: this is mostly a copy-paste of the issue description, I suspect it's something that already approved. I did few additions:
|
|
Looks fine to me. |
|
Nit: not sure what the line-length conventions should be for Markdown files. The file is currently 1 file line per paragraph. Is it worth reflowing? |
Other files wrap lines close to PEP 8 limit. Though, not all. E.g.
It's just to simplify comparison with the issue description. |
|
Please do wrap, for people viewing locally in non-wrapping editors it makes life much easier. |
Ok, done. Though, I suspect people will want to see rendered TeX... |
|
@mdickinson if you’re happy, I can merge this, could you please review? |
|
I won't be in a position to review effectively for around a week (on vacation without access to a real keyboard; phone doesn't count). I'm sure any changes I might ask for would be nitpick level, and I don't want to block this. I'm happy to do a post-merge review next week. Thanks @skirpichev for pushing this through! |
|
I'm afraid I'm not familiar enough here to review properly, but I think a week's wait should be alright. |
|
Nit: can we make the link to the formal proof an actual link rather than a code block? |
This includes correctness proof of Fraction.limit_denominator by Mark Dickinson.
Fraction.limit_denominator#95723