Repository navigation
gh-162364: Speed up test_signal StressTest.test_stress_delivery_simultaneous - #162366
Merged
Merged
Conversation
…_simultaneous Reuse the short-sleep polling loop from test_stress_delivery_dependent. The 10 ms minimum sleep of sleeping_retry() dominated the test's runtime, especially under macOS background QoS where timer coalescing stretches each sleep. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
!buildbot ARM64 MacOS M1 Refleaks NoGIL PR |
|
🤖 New build scheduled with the buildbot fleet by @cmaloney for commit 6d8e1e4 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F162366%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
The wait avoids coalescing of pending signals; timer coalescing on macOS is what made the old 10 ms sleep so slow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
From the bot: |
kumaraditya303
approved these changes
Nov 21, 2026
|
Thanks @cmaloney for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-162401 is a backport of this pull request to the 3.15 branch. |
|
GH-162402 is a backport of this pull request to the 3.14 branch. |
cmaloney
added a commit
that referenced
this pull request
Nov 21, 2026
…y_simultaneous (GH-162366) (#162401) gh-162364: Speed up test_signal StressTest.test_stress_delivery_simultaneous (GH-162366) Reuse the short-sleep polling loop from test_stress_delivery_dependent. The 10 ms minimum sleep of sleeping_retry() dominated the test's runtime, especially under macOS background QoS where timer coalescing stretches each sleep. (cherry picked from commit 3fd6401) Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
cmaloney
added a commit
that referenced
this pull request
Nov 21, 2026
…y_simultaneous (GH-162366) (#162402) gh-162364: Speed up test_signal StressTest.test_stress_delivery_simultaneous (GH-162366) Reuse the short-sleep polling loop from test_stress_delivery_dependent. The 10 ms minimum sleep of sleeping_retry() dominated the test's runtime, especially under macOS background QoS where timer coalescing stretches each sleep. (cherry picked from commit 3fd6401) Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse the short-sleep polling loop from test_stress_delivery_dependent. The 10 ms minimum sleep of sleeping_retry() dominated the test's runtime, especially under macOS background QoS where timer coalescing stretches each sleep.