Skip to content

feat(dsv): support dsv files imported with import attributes in Rollup 5 - #2050

Open
TrickyPi wants to merge 2 commits into
rollup:masterfrom
TrickyPi:feat/rollup-5/dsv
Open

TrickyPi wants to merge 2 commits into
rollup:masterfrom
TrickyPi:feat/rollup-5/dsv

Conversation

@TrickyPi

@TrickyPi TrickyPi commented Nov 22, 2026 •

Copy link
Copy Markdown
Member

Rollup Plugin Name: dsv

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

In Rollup 5, import attributes are appended to id as a query string, with the original ID passed via rawId. Allow the query suffix in transform.filter.id and use transformOptions.rawId (falling back to id) in transform.handler.

@TrickyPi
TrickyPi requested a review from shellscape as a code owner November 22, 2026 04:50
@greptile-apps

greptile-apps Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5

[Low impact] The changes are limited to the dsv plugin’s CSV and TSV import workflow.

Align the Rollup build dependency with the Node versions used by CI before merging.

Findings

  1. P1 Rollup outgrows Node 20 ▶

Reviews (2) · Last reviewed commit: "test(dsv): run tests against Rollup 5 vi..." · Reviewed by Greptile

Comment thread packages/dsv/test/test.js Resolved
@TrickyPi TrickyPi changed the title fix(dsv): handle dsv files imported with import attributes in Rollup 5 feat(dsv): support dsv files imported with import attributes in Rollup 5 Nov 22, 2026
Comment thread packages/dsv/package.json
"devDependencies": {
"del-cli": "^5.0.0",
"rollup": "^4.0.0-24"
"rollup": "catalog:rollup-next"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Rollup outgrows Node 20

Switching dsv to catalog:rollup-next selects Rollup 5.0.0-2, which requires Node >=22.22.0. Both CI workflows still build or test this package on Node 20, and .nvmrc also selects Node 20. These jobs and contributors now run the build with an unsupported Node version.

Keep the Node 20 jobs on a supported Rollup version, or update the runtime setup alongside this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant