Repository navigation
Conversation
[Low impact] The changes are limited to the dsv plugin’s CSV and TSV import workflow. Align the Rollup build dependency with the Node versions used by CI before merging. Findings
Reviews (2) · Last reviewed commit: "test(dsv): run tests against Rollup 5 vi..." · Reviewed by Greptile |
| "devDependencies": { | ||
| "del-cli": "^5.0.0", | ||
| "rollup": "^4.0.0-24" | ||
| "rollup": "catalog:rollup-next" |
There was a problem hiding this comment.
Switching dsv to catalog:rollup-next selects Rollup 5.0.0-2, which requires Node >=22.22.0. Both CI workflows still build or test this package on Node 20, and .nvmrc also selects Node 20. These jobs and contributors now run the build with an unsupported Node version.
Keep the Node 20 jobs on a supported Rollup version, or update the runtime setup alongside this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
dsvThis PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
In Rollup 5, import attributes are appended to
idas a query string, with the original ID passed viarawId. Allow the query suffix intransform.filter.idand usetransformOptions.rawId(falling back toid) intransform.handler.