Skip to content

feat(graphql): support graphql files imported with import attributes in Rollup 5 - #2055

Open
TrickyPi wants to merge 2 commits into
rollup:masterfrom
TrickyPi:feat/rollup-5/graphql
Open

TrickyPi wants to merge 2 commits into
rollup:masterfrom
TrickyPi:feat/rollup-5/graphql

Conversation

@TrickyPi

@TrickyPi TrickyPi commented Nov 22, 2026 •

Copy link
Copy Markdown
Member

Rollup Plugin Name: graphql

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

In Rollup 5, import attributes are appended to id as a query string, with the original ID passed via rawId. Allow the query suffix in transform.filter.id and use transformOptions.rawId (falling back to id) in transform.handler.

@TrickyPi
TrickyPi requested a review from shellscape as a code owner November 22, 2026 04:52
@greptile-apps

greptile-apps Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge, with no new actionable issues found.

Reviews (2) · Last reviewed commit: "test(graphql): run tests against Rollup ..." · Reviewed by Greptile

Comment thread packages/graphql/test/test.js Resolved
@TrickyPi TrickyPi changed the title fix(graphql): handle graphql files imported with import attributes in Rollup 5 feat(graphql): support graphql files imported with import attributes in Rollup 5 Nov 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant