Repository navigation
duckdb: preserve OFFSET parameters with a percentage LIMIT - #4701
Open
1akashkalita wants to merge 1 commit into
Open
1akashkalita wants to merge 1 commit into
1akashkalita wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On main, sqlc drops the offset parameter from this DuckDB query:
sqlc analyzereports an empty parameter list. The generated Go method callsQueryContextwithout an argument for$1. DuckDB accepts the query and expects the offset at execution time.The DuckDB converter skips the entire limit modifier when the limit is a percentage. This change narrows that check to the limit count so the offset goes through the existing row-offset conversion. The end-to-end regression checks that the analyzer reports parameter 1.
I reproduced the missing argument on main, exercised the prepared query in DuckDB 1.4.1, and verified the generated Go method forwards its offset after the fix. The regression failed on main and passed with this change. The base replay suite and the core, DuckDB engine and compiler package tests passed with Go 1.26.5.