Repository navigation
fix(core): handle host bits in Docker network subnets - #1150
Open
archit15singh wants to merge 1 commit into
Open
archit15singh wants to merge 1 commit into
archit15singh wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #907.
When Docker reports a subnet such as
172.18.251.1/25, host network discovery raisesValueErrorand container startup stops. Parse the subnet withstrict=Falseso the prefix determines membership. The tests cover a host inside the reported prefix, one outside it, and a canonical network address.I exercised the Docker SDK against a local HTTP fixture serving Docker's network-list response. I also ran the focused Docker client tests and Ruff locally. I also ran the Docker client and network test modules against Docker Engine 28.5.2. All five network integration tests passed, including communication between two running containers. Of 54 tests, 53 passed. The remaining test also fails on main with an explicit Docker socket and is addressed in #1153. The engine returned the expected canonical subnet for a real bridge and rejected creation of a noncanonical subnet, so the original host-bit regression is covered by the HTTP fixture.
Local verification
Base
6146aa1170f415fcc825ed9bddc4eacbeb937a12· Candidate3757b2d7a9f5bc83221e65b5e4329ecb99c1dd2f· macOS-27.0.1-arm64-arm-64bit-Mach-OReplay receipt, commands, and logs