Skip to content

fix(core): handle host bits in Docker network subnets - #1150

Open
archit15singh wants to merge 1 commit into
testcontainers:mainfrom
archit15singh:fix/host-bits-in-network-subnet
Open

archit15singh wants to merge 1 commit into
testcontainers:mainfrom
archit15singh:fix/host-bits-in-network-subnet

Conversation

@archit15singh

@archit15singh archit15singh commented Nov 21, 2026 •

Copy link
Copy Markdown

Fixes #907.

When Docker reports a subnet such as 172.18.251.1/25, host network discovery raises ValueError and container startup stops. Parse the subnet with strict=False so the prefix determines membership. The tests cover a host inside the reported prefix, one outside it, and a canonical network address.

I exercised the Docker SDK against a local HTTP fixture serving Docker's network-list response. I also ran the focused Docker client tests and Ruff locally. I also ran the Docker client and network test modules against Docker Engine 28.5.2. All five network integration tests passed, including communication between two running containers. Of 54 tests, 53 passed. The remaining test also fails on main with an explicit Docker socket and is addressed in #1153. The engine returned the expected canonical subnet for a real bridge and rejected creation of a noncanonical subnet, so the original host-bit regression is covered by the HTTP fixture.

Local verification

Base 6146aa1170f415fcc825ed9bddc4eacbeb937a12 · Candidate 3757b2d7a9f5bc83221e65b5e4329ecb99c1dd2f · macOS-27.0.1-arm64-arm-64bit-Mach-O

Check Base Candidate
DockerClient.find_host_network() using the Docker SDK and a local network-list HTTP fixture ValueError: 127.0.0.7/25 has host bits set selected=runner-network
Python 3.13 Passed Passed
Canonical network matches Docker host Passed Passed
Docker host outside canonical network Passed Passed
Malformed network entry is skipped Passed Passed
32 Docker client tests including three subnet regression cases — Passed

Replay receipt, commands, and logs

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: DockerClient fails to start with auto-detected network and host bits set

1 participant