Repository navigation
feat(core): stream a container file into a binary destination - #1152
Open
archit15singh wants to merge 1 commit into
Open
archit15singh wants to merge 1 commit into
archit15singh wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1149. A caller can now copy one regular file into an open binary stream, including a BytesIO or a network writer, without creating a temporary file.
The transfer reads Docker's tar stream incrementally, handles short writes, and leaves the destination open. The existing path-based copy method is unchanged.
I tested a 4 MiB binary file against Docker Engine 28.5.2. The destination received multiple bounded writes with the expected SHA-256. The suite also checks that the first write occurs before all input has arrived and that a directory is rejected. Ryuk was disabled for the isolated local daemon.
Local verification
Base
6146aa1170f415fcc825ed9bddc4eacbeb937a12· Candidate5a2b745d431baaa112869c48fe3e846f1b3d749a· macOS-27.0.1-arm64-arm-64bit-Mach-OReplay receipt, commands, and logs