Skip to content

Zend: refactor type checking and unify const, prop, arg, and return values - #21580

Draft
Girgias wants to merge 2 commits into
php:masterfrom
Girgias:2026-03-type-checking-merge
Draft

Girgias wants to merge 2 commits into
php:masterfrom
Girgias:2026-03-type-checking-merge

Conversation

@Girgias

@Girgias Girgias commented Mar 30, 2026 •

Copy link
Copy Markdown
Member

W.I.P. this is an attempt to unify the type checking logic so that class properties and constants use the same routines as arguments and return values for functions.

Pre-requisites:

  • Implement Stringable on GMP object
  • Implement Stringable on ext/com variant object

@Girgias
Girgias force-pushed the 2026-03-type-checking-merge branch from ff7eca7 to 79c7881 Compare March 30, 2026 21:54
@Girgias
Girgias force-pushed the 2026-03-type-checking-merge branch from fe9560a to 79c99b4 Compare March 31, 2026 19:42
@Girgias
Girgias force-pushed the 2026-03-type-checking-merge branch 2 times, most recently from 590ee76 to b74504e Compare May 4, 2026 13:27
@Girgias
Girgias force-pushed the 2026-03-type-checking-merge branch from 314eb09 to 3842992 Compare November 20, 2026 17:47
@php php deleted a comment from github-actions Bot Nov 20, 2026
@php php deleted a comment from github-actions Bot Nov 20, 2026
@php php deleted a comment from github-actions Bot Nov 20, 2026
@php php deleted a comment from github-actions Bot Nov 20, 2026
@php php deleted a comment from github-actions Bot Nov 20, 2026
@php php deleted a comment from github-actions Bot Nov 20, 2026
@Girgias
Girgias force-pushed the 2026-03-type-checking-merge branch 2 times, most recently from e8ec9f3 to 5491bdd Compare November 20, 2026 21:03
@github-actions

Copy link
Copy Markdown

AWS x86_64 (c6id.metal)

Attribute Value
Environment aws
Instance type c6id.metal
Architecture x86_64
CPU Intel(R) Xeon(R) Platinum 8375C CPU @ 2.90GHz, 64 cores @ 2900 MHz
CPU settings disabled deeper C-states, disabled turbo boost, disabled hyper-threading
RAM 251 GB
Kernel 6.18.56-125.164.amzn2023.x86_64
OS Amazon Linux 2023.12.20261026
GCC 14.2.1
Binary layout strategy bolt-align
Time 2026-11-21 21:07:23 UTC
Job details https://github.com/php/php-src/actions/runs/44949835646 (Artifacts)
Changeset https://github.com/php/php-src/compare/f1c7f2d4f7..5491bdd07c

Laravel 12.11.0 demo app - 50 iterations, 50 warmups, 100 requests (sec)

PHP Min Max Std dev Rel std dev % Mean Mean diff % Median Median diff % Skewness Z-stat P-value Memory
PHP - baseline@f1c7f2d 0.38088 0.38204 0.00023 0.06% 0.38119 0.00% 0.38115 0.00% 1.944 0.000 1.000 31.26 MB
PHP - 2026-03-type-checking-merge 0.38265 0.38393 0.00022 0.06% 0.38293 0.45% 0.38289 0.45% 2.245 -8.614 0.000 31.24 MB

Symfony 2.8.0 demo app - 50 iterations, 50 warmups, 100 requests (sec)

PHP Min Max Std dev Rel std dev % Mean Mean diff % Median Median diff % Skewness Z-stat P-value Memory
PHP - baseline@f1c7f2d 0.68817 0.70561 0.00266 0.39% 0.68930 0.00% 0.68863 0.00% 5.348 0.000 1.000 31.73 MB
PHP - 2026-03-type-checking-merge 0.68764 0.69821 0.00168 0.24% 0.68914 -0.02% 0.68876 0.02% 3.493 0.265 0.791 31.70 MB

Wordpress 6.9 main page - 50 iterations, 20 warmups, 20 requests (sec)

PHP Min Max Std dev Rel std dev % Mean Mean diff % Median Median diff % Skewness Z-stat P-value Memory
PHP - baseline@f1c7f2d 0.58738 0.59099 0.00055 0.09% 0.58800 0.00% 0.58795 0.00% 3.464 0.000 1.000 31.79 MB
PHP - 2026-03-type-checking-merge 0.59003 0.59215 0.00034 0.06% 0.59057 0.44% 0.59058 0.45% 1.973 -8.283 0.000 31.76 MB

bench.php - 50 iterations, 20 warmups, 2 requests (sec)

PHP Min Max Std dev Rel std dev % Mean Mean diff % Median Median diff % Skewness Z-stat P-value Memory
PHP - baseline@f1c7f2d 0.45157 0.45645 0.00069 0.15% 0.45273 0.00% 0.45278 0.00% 2.940 0.000 1.000 31.79 MB
PHP - 2026-03-type-checking-merge 0.45175 0.45361 0.00035 0.08% 0.45247 -0.06% 0.45247 -0.07% 0.938 3.137 0.002 31.76 MB

@Girgias
Girgias force-pushed the 2026-03-type-checking-merge branch from 5491bdd to 42728de Compare November 21, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant