Repository navigation
test(core): isolate Docker host selection in the run test - #1153
Open
archit15singh wants to merge 1 commit into
Open
archit15singh wants to merge 1 commit into
archit15singh wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The network selection unit test fails on a custom Docker socket. It expects a discovered network even though an explicit Docker host tells the client to skip discovery. The same failure was reported on Colima in #1146.
I reproduced the original failure with Docker Engine 28.5.2 on a Unix socket and ran the Docker client and network test modules against the same engine. The network integration tests start two Nginx containers and check communication by container name and alias.
Both new cases also pass with a missing socket. As a check on the assertions, I temporarily forced discovery on and then off. Each change failed the corresponding test case and left the other passing. The two complete test modules passed all 53 cases on the submitted revision.
Local verification
Base
6146aa1170f415fcc825ed9bddc4eacbeb937a12· Candidate8730b6c01c654892eba340ef0972143726647865· macOS-27.0.1-arm64-arm-64bit-Mach-OReplay receipt, commands, and logs