Skip to content

test(core): isolate Docker host selection in the run test - #1153

Open
archit15singh wants to merge 1 commit into
testcontainers:mainfrom
archit15singh:fix/isolate-network-discovery-test
Open

archit15singh wants to merge 1 commit into
testcontainers:mainfrom
archit15singh:fix/isolate-network-discovery-test

Conversation

@archit15singh

@archit15singh archit15singh commented Nov 22, 2026 •

Copy link
Copy Markdown

The network selection unit test fails on a custom Docker socket. It expects a discovered network even though an explicit Docker host tells the client to skip discovery. The same failure was reported on Colima in #1146.

Before  run network selection test with custom socket -> expects discovery -> KeyError: 'network'
After   run network selection test with custom socket -> checks that discovery is skipped -> passes

I reproduced the original failure with Docker Engine 28.5.2 on a Unix socket and ran the Docker client and network test modules against the same engine. The network integration tests start two Nginx containers and check communication by container name and alias.

Both new cases also pass with a missing socket. As a check on the assertions, I temporarily forced discovery on and then off. Each change failed the corresponding test case and left the other passing. The two complete test modules passed all 53 cases on the submitted revision.

Local verification

Base 6146aa1170f415fcc825ed9bddc4eacbeb937a12 · Candidate 8730b6c01c654892eba340ef0972143726647865 · macOS-27.0.1-arm64-arm-64bit-Mach-O

Check Base Candidate
Upstream network selection test with an explicit Unix socket to Docker Engine KeyError: 'network' passed
Disposable Docker Engine Passed Passed
Canonical subnet discovery Passed Passed
Empty Docker context Passed Passed
Invalid network address Passed Passed
Complete Docker client and Docker network test modules — Passed

Replay receipt, commands, and logs

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant